Newcomer with a few patches
-
- Elite
- Posts: 7243
- Joined: Mon Apr 18, 2005 2:40 pm
- Location: LS87, Buenos Aires, República Argentina
Re: Newcomer with a few patches
Which ones do you see still relevant to trunk? (AFAIR, I had reviewed and merged quite a few)
-
- Merchant
- Posts: 35
- Joined: Mon Jul 04, 2011 5:32 pm
Re: Newcomer with a few patches
patch 15
http://sourceforge.net/p/vegastrike/pat ... ref-1.diff
still looks applicable with a 1 line offset but which is arguably of gret value, but still...
and I thought patches from #26 were, but they are no more relevant
So thank you for applying my previous batch, I may still continue to send that kind of small fixes, and maybe more, c.f.
http://forums.vega-strike.org/viewtopic ... 21&t=18591
http://sourceforge.net/p/vegastrike/pat ... ref-1.diff
still looks applicable with a 1 line offset but which is arguably of gret value, but still...
and I thought patches from #26 were, but they are no more relevant
So thank you for applying my previous batch, I may still continue to send that kind of small fixes, and maybe more, c.f.
http://forums.vega-strike.org/viewtopic ... 21&t=18591
-
- Merchant
- Posts: 35
- Joined: Mon Jul 04, 2011 5:32 pm
Re: Newcomer with a few patches
and patches 9 & 12 needed more work, so, I'll get back to them too...
-
- Elite
- Posts: 7243
- Joined: Mon Apr 18, 2005 2:40 pm
- Location: LS87, Buenos Aires, República Argentina
Re: Newcomer with a few patches
Ok, committed.vincele wrote:patch 15
http://sourceforge.net/p/vegastrike/pat ... ref-1.diff
still looks applicable with a 1 line offset but which is arguably of gret value, but still...
-
- Elite
- Posts: 1567
- Joined: Tue Jan 26, 2010 2:03 am
Re: Newcomer with a few patches
Most of the latest work was getting py3 working with the engine before merging with trunk. Most work is back to trunk I think, though I would like to revive my old branch for some tinkering and profiling.
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
-
- Merchant
- Posts: 35
- Joined: Mon Jul 04, 2011 5:32 pm
Re: Newcomer with a few patches
OK good to know.
I've got a new batch of smallish cleanups and fixes, mainly for data/modules python files, but what I found made me ask if all that is still in real use, because there's real bugs in there... For example, is spectre.py used at all ?
What do I do with that batch as I cannot use SF.net currently, and I don't know how to fix that, maybe create a new account...
I've got a new batch of smallish cleanups and fixes, mainly for data/modules python files, but what I found made me ask if all that is still in real use, because there's real bugs in there... For example, is spectre.py used at all ?
What do I do with that batch as I cannot use SF.net currently, and I don't know how to fix that, maybe create a new account...
-
- Merchant
- Posts: 35
- Joined: Mon Jul 04, 2011 5:32 pm
Re: Newcomer with a few patches
OK SF.net back working properly, so small fixes batch is here :
https://sourceforge.net/p/vegastrike/patches/59/ and here
https://sourceforge.net/p/vegastrike/patches/60/
How can I be marked "owner" of those bug reports ? And maybe the 9, 12, 15 & 26 ones too...
https://sourceforge.net/p/vegastrike/patches/59/ and here
https://sourceforge.net/p/vegastrike/patches/60/
How can I be marked "owner" of those bug reports ? And maybe the 9, 12, 15 & 26 ones too...
-
- Elite
- Posts: 7243
- Joined: Mon Apr 18, 2005 2:40 pm
- Location: LS87, Buenos Aires, República Argentina
Re: Newcomer with a few patches
I've been seeing those patch tracker mails pile up lately. Sorry for the delay, but I've been sick. As soon as I'm able I'll start reviewing them.vincele wrote:OK SF.net back working properly, so small fixes batch is here :
https://sourceforge.net/p/vegastrike/patches/59/ and here
https://sourceforge.net/p/vegastrike/patches/60/
How can I be marked "owner" of those bug reports ? And maybe the 9, 12, 15 & 26 ones too...
-
- Merchant
- Posts: 35
- Joined: Mon Jul 04, 2011 5:32 pm
Re: Newcomer with a few patches
No problem, I'll just continue to pile up on those, and already have added two more...
Do you agree with the granularity or is it split too much ?
I like very small independent things, I think it's easier to review/apply...
Do you agree with the granularity or is it split too much ?
I like very small independent things, I think it's easier to review/apply...
-
- Elite
- Posts: 7243
- Joined: Mon Apr 18, 2005 2:40 pm
- Location: LS87, Buenos Aires, República Argentina
Re: Newcomer with a few patches
I haven't seen them yet, but in general, the more they're split the better, as long as all related changes are on the same patch (ie: one atomic fix per patch, no more, no less). So, if you fixed an expression that is used in 5 places, you'd fix those 5 places in one patch, rather than 5 patches.vincele wrote:No problem, I'll just continue to pile up on those, and already have added two more...
Do you agree with the granularity or is it split too much ?
I like very small independent things, I think it's easier to review/apply...