Laughable code comment of the day

Development directions, tasks, and features being actively implemented or pursued by the development team.

Laughable code comment of the day

Postby pheonixstorm » Thu Mar 15, 2012 11:04 pm

line 685 unit_xml.cpp
//mem leak...but hey--only for mpl
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
User avatar
pheonixstorm
Elite
Elite
 
Posts: 1567
Topics: 113
Joined: Mon Jan 25, 2010 7:03 pm

Share On:

Share on Facebook Facebook Share on Twitter Twitter Share on Digg Digg

Re: Laughable code comment of the day

Postby klauss » Fri Mar 16, 2012 8:52 am

That begs for a patch.
Oíd mortales, el grito sagrado...
Call me "Menes, lord of Cats"
Wing Commander Universe
User avatar
klauss
Elite
Elite
 
Posts: 7243
Topics: 55
Joined: Mon Apr 18, 2005 7:40 am
Location: LS87, Buenos Aires, República Argentina

Re: Laughable code comment of the day

Postby pheonixstorm » Fri Mar 16, 2012 9:24 am

I've seen a lot of code comments like this, but that was the most humorous.
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
User avatar
pheonixstorm
Elite
Elite
 
Posts: 1567
Topics: 113
Joined: Mon Jan 25, 2010 7:03 pm

Re: Laughable code comment of the day

Postby pheonixstorm » Fri Mar 16, 2012 11:40 pm

here's one from unit_generic.cpp
In short I have NO CLUE how this works! It just...grudgingly does
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
User avatar
pheonixstorm
Elite
Elite
 
Posts: 1567
Topics: 113
Joined: Mon Jan 25, 2010 7:03 pm

Re: Laughable code comment of the day

Postby klauss » Sat Mar 17, 2012 1:24 pm

:lol: now that's laughable
Oíd mortales, el grito sagrado...
Call me "Menes, lord of Cats"
Wing Commander Universe
User avatar
klauss
Elite
Elite
 
Posts: 7243
Topics: 55
Joined: Mon Apr 18, 2005 7:40 am
Location: LS87, Buenos Aires, República Argentina

Re: Laughable code comment of the day

Postby travists » Sat Mar 17, 2012 2:39 pm

I can see how it would happen. When I was programming regularly (other interests lately) I would occasionally run across a rather useful bug. But if it only works “grudgingly”, why point out that fact? Highlights you don't need to be a programming wiz or pro to contribute! :lol:
User avatar
travists
Expert Mercenary
Expert Mercenary
 
Posts: 893
Topics: 33
Joined: Thu Jul 08, 2010 4:43 pm
Location: Sol III North American Continent

Re: Laughable code comment of the day

Postby pheonixstorm » Mon Mar 19, 2012 1:30 am

here is today's winners.

//sorry boyz...I'm just a tourist with a frag nav console--could you tell me where I am?
Unit * getTopLevelOwner() //returns terrible memory--don't dereference...ever...not even aligned
{
return (Unit*) 0x31337; //FIXME How about telling us a little story behind this function? --chuck_starchaser
}


don't forget
slow but who cares
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
User avatar
pheonixstorm
Elite
Elite
 
Posts: 1567
Topics: 113
Joined: Mon Jan 25, 2010 7:03 pm

Re: Laughable code comment of the day

Postby klauss » Mon Mar 19, 2012 8:30 am

I've seen that one too. Those are the things that make you want to rewrite it all from scratch.

Thing is... it's a helluva lot of work to write VS from scratch.
Oíd mortales, el grito sagrado...
Call me "Menes, lord of Cats"
Wing Commander Universe
User avatar
klauss
Elite
Elite
 
Posts: 7243
Topics: 55
Joined: Mon Apr 18, 2005 7:40 am
Location: LS87, Buenos Aires, República Argentina

Re: Laughable code comment of the day

Postby pheonixstorm » Mon Mar 19, 2012 11:58 pm

but from a code stand point.. One would be better off with a rewrite ,I think, rather than doing a complete refactoring :lol: At least for a rewrite there is the vega strike code and decent freespace 2 code to use as a template on ways to (and not to) do things.
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
User avatar
pheonixstorm
Elite
Elite
 
Posts: 1567
Topics: 113
Joined: Mon Jan 25, 2010 7:03 pm

Re: Laughable code comment of the day

Postby pheonixstorm » Tue Mar 20, 2012 1:24 am

when computer says nasty things to you it hurts
:roll:
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
User avatar
pheonixstorm
Elite
Elite
 
Posts: 1567
Topics: 113
Joined: Mon Jan 25, 2010 7:03 pm

Re: Laughable code comment of the day

Postby pheonixstorm » Tue Mar 20, 2012 2:37 am

//You died or something... too bad.
:lol:
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
User avatar
pheonixstorm
Elite
Elite
 
Posts: 1567
Topics: 113
Joined: Mon Jan 25, 2010 7:03 pm

Re: Laughable code comment of the day

Postby Primordial » Wed Mar 21, 2012 4:20 am

So glad I'm not a programmer...
Primordial
Merchant
Merchant
 
Posts: 62
Topics: 5
Joined: Tue Jun 21, 2011 3:33 pm

Re: Laughable code comment of the day

Postby Deus Siddis » Sun Mar 25, 2012 11:56 am

pheonixstorm wrote:One would be better off with a rewrite ,I think, rather than doing a complete refactoring :lol: At least for a rewrite there is the vega strike code and decent freespace 2 code to use as a template on ways to (and not to) do things.


Also keep in mind Pioneer. It is young but shows much promise in areas VS always dreamed about but never reached.
Deus Siddis
Elite
Elite
 
Posts: 1362
Topics: 13
Joined: Sat Aug 04, 2007 8:42 am

Re: Laughable code comment of the day

Postby travists » Mon Mar 26, 2012 10:21 am

May have to check it out.
Deus Siddis wrote:shows much promise in areas VS always dreamed about

Anything that VS could offer in the way of a partnership? It is opensource, so could just credit them and lift the parts useful to our little game, but would be better if we could offer something in return.
User avatar
travists
Expert Mercenary
Expert Mercenary
 
Posts: 893
Topics: 33
Joined: Thu Jul 08, 2010 4:43 pm
Location: Sol III North American Continent

Re: Laughable code comment of the day

Postby klauss » Mon Mar 26, 2012 10:30 am

In return (or not) they can pull out whatever code they want.

That's the OSS way anyway.
Oíd mortales, el grito sagrado...
Call me "Menes, lord of Cats"
Wing Commander Universe
User avatar
klauss
Elite
Elite
 
Posts: 7243
Topics: 55
Joined: Mon Apr 18, 2005 7:40 am
Location: LS87, Buenos Aires, República Argentina

Re: Laughable code comment of the day

Postby travists » Mon Mar 26, 2012 10:37 am

I was A not wanting to step on any toes, and B thinking a partner project or mutual aid kind of thing. But, if they can do something we can't as both are open source projects grab and run!! The nice way is my usual starting point.
User avatar
travists
Expert Mercenary
Expert Mercenary
 
Posts: 893
Topics: 33
Joined: Thu Jul 08, 2010 4:43 pm
Location: Sol III North American Continent

Re: Laughable code comment of the day

Postby klauss » Mon Mar 26, 2012 10:47 am

Grab and run is the nice way.

If there are commonalities among the projects, cooperation may ensue, but I'm not entirely sure that is the case. There's a high degree of specificity required in order to share software components. In any case, if I grab something from a project and see an oportunity to fork that something into a library so that we can both develop that part together, that should be done.

In essence, it's grab, run... maybe return with a gift.
Oíd mortales, el grito sagrado...
Call me "Menes, lord of Cats"
Wing Commander Universe
User avatar
klauss
Elite
Elite
 
Posts: 7243
Topics: 55
Joined: Mon Apr 18, 2005 7:40 am
Location: LS87, Buenos Aires, República Argentina

Re: Laughable code comment of the day

Postby travists » Mon Mar 26, 2012 11:11 am

If nothing else seeing how something that is lacking here is done elsewhere should help, I would think.
User avatar
travists
Expert Mercenary
Expert Mercenary
 
Posts: 893
Topics: 33
Joined: Thu Jul 08, 2010 4:43 pm
Location: Sol III North American Continent

Re: Laughable code comment of the day

Postby klauss » Mon Mar 26, 2012 11:16 am

I would like to mention, that the new sound system (which I've called SUCSS) is modular enough to be forkable.

I haven't forked it because it entails a bit of extra effort in order to fully divorce its code from VS code (it shares a few helper classes), but it was always my intention to fork it as soon as it's mature enough.

So, if any project (not just Pioneer) is in need of an extensible and modular sound system, they should express interest in SUCSS, for if there is interest I can invest some effort into forking it sooner.
Oíd mortales, el grito sagrado...
Call me "Menes, lord of Cats"
Wing Commander Universe
User avatar
klauss
Elite
Elite
 
Posts: 7243
Topics: 55
Joined: Mon Apr 18, 2005 7:40 am
Location: LS87, Buenos Aires, República Argentina

Re: Laughable code comment of the day

Postby loki1950 » Mon Mar 26, 2012 12:16 pm

I downloaded it yesterday :) It seems to be OGRE based and they use Lua as their scripting language I don't much like there control paradigm yet though there auto-pilot is nice,do like the their landing/takeoff animations.


Enjoy the Choice :)
my box::HP Envy i5-6400 @2Q70GHzx4 8 Gb ram/1 Tb(Win10 64)/3 Tb Mint 18/GTX745 4Gb acer S243HL K222HQL
Q8200/Asus P5QDLX/8 Gb ram/WD 2Tb 2-500 G HD/GF GT640 2Gb Mint 17.3 64 bit Win 10 32 bit acer and DELL E6400 4GB ram/100 GB HD Mint 17.3 6
User avatar
loki1950
The Shepherd
 
Posts: 5701
Topics: 51
Joined: Fri May 13, 2005 1:37 pm
Location: Ottawa

Re: Laughable code comment of the day

Postby pheonixstorm » Mon Mar 26, 2012 3:40 pm

klauss wrote:So, if any project (not just Pioneer) is in need of an extensible and modular sound system, they should express interest in SUCSS, for if there is interest I can invest some effort into forking it sooner.


Then you might as well create a new SF project. Thats how the GiGi gui for/from freeorion was done. I don't remember the full history off hand but it was either designed for freeorion or from it, but in either case it is a seperate project on sourceforge.
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
User avatar
pheonixstorm
Elite
Elite
 
Posts: 1567
Topics: 113
Joined: Mon Jan 25, 2010 7:03 pm

Re: Laughable code comment of the day

Postby klauss » Mon Mar 26, 2012 6:11 pm

I know, with fork i mean that. It's just an amount of work I'm not ready to invest yet in its infantile form to get it independent, and a commitment to interface stability i cannot guarantee just yet.
Oíd mortales, el grito sagrado...
Call me "Menes, lord of Cats"
Wing Commander Universe
User avatar
klauss
Elite
Elite
 
Posts: 7243
Topics: 55
Joined: Mon Apr 18, 2005 7:40 am
Location: LS87, Buenos Aires, República Argentina



Return to Engine Development

Who is online

Users browsing this forum: No registered users and 1 guest

cron