//mem leak...but hey--only for mpl
Laughable code comment of the day
-
- Elite
- Posts: 1567
- Joined: Tue Jan 26, 2010 2:03 am
Laughable code comment of the day
line 685 unit_xml.cpp
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
-
- Elite
- Posts: 7243
- Joined: Mon Apr 18, 2005 2:40 pm
- Location: LS87, Buenos Aires, República Argentina
Re: Laughable code comment of the day
That begs for a patch.
-
- Elite
- Posts: 1567
- Joined: Tue Jan 26, 2010 2:03 am
Re: Laughable code comment of the day
I've seen a lot of code comments like this, but that was the most humorous.
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
-
- Elite
- Posts: 1567
- Joined: Tue Jan 26, 2010 2:03 am
Re: Laughable code comment of the day
here's one from unit_generic.cpp
In short I have NO CLUE how this works! It just...grudgingly does
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
-
- Elite
- Posts: 7243
- Joined: Mon Apr 18, 2005 2:40 pm
- Location: LS87, Buenos Aires, República Argentina
Re: Laughable code comment of the day
![Laughing :lol:](./images/smilies/icon_lol.gif)
-
- Expert Mercenary
- Posts: 893
- Joined: Thu Jul 08, 2010 11:43 pm
- Location: Sol III North American Continent
Re: Laughable code comment of the day
I can see how it would happen. When I was programming regularly (other interests lately) I would occasionally run across a rather useful bug. But if it only works “grudgingly”, why point out that fact? Highlights you don't need to be a programming wiz or pro to contribute! ![Laughing :lol:](./images/smilies/icon_lol.gif)
![Laughing :lol:](./images/smilies/icon_lol.gif)
-
- Elite
- Posts: 1567
- Joined: Tue Jan 26, 2010 2:03 am
Re: Laughable code comment of the day
here is today's winners.
don't forget//sorry boyz...I'm just a tourist with a frag nav console--could you tell me where I am?
Unit * getTopLevelOwner() //returns terrible memory--don't dereference...ever...not even aligned
{
return (Unit*) 0x31337; //FIXME How about telling us a little story behind this function? --chuck_starchaser
}
slow but who cares
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
-
- Elite
- Posts: 7243
- Joined: Mon Apr 18, 2005 2:40 pm
- Location: LS87, Buenos Aires, República Argentina
Re: Laughable code comment of the day
I've seen that one too. Those are the things that make you want to rewrite it all from scratch.
Thing is... it's a helluva lot of work to write VS from scratch.
Thing is... it's a helluva lot of work to write VS from scratch.
-
- Elite
- Posts: 1567
- Joined: Tue Jan 26, 2010 2:03 am
Re: Laughable code comment of the day
but from a code stand point.. One would be better off with a rewrite ,I think, rather than doing a complete refactoring
At least for a rewrite there is the vega strike code and decent freespace 2 code to use as a template on ways to (and not to) do things.
![Laughing :lol:](./images/smilies/icon_lol.gif)
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
-
- Elite
- Posts: 1567
- Joined: Tue Jan 26, 2010 2:03 am
Re: Laughable code comment of the day
when computer says nasty things to you it hurts
![Rolling Eyes :roll:](./images/smilies/icon_rolleyes.gif)
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
-
- Elite
- Posts: 1567
- Joined: Tue Jan 26, 2010 2:03 am
Re: Laughable code comment of the day
//You died or something... too bad.
![Laughing :lol:](./images/smilies/icon_lol.gif)
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
-
- Merchant
- Posts: 62
- Joined: Tue Jun 21, 2011 10:33 pm
Re: Laughable code comment of the day
So glad I'm not a programmer...
-
- Elite
- Posts: 1363
- Joined: Sat Aug 04, 2007 3:42 pm
Re: Laughable code comment of the day
Also keep in mind Pioneer. It is young but shows much promise in areas VS always dreamed about but never reached.pheonixstorm wrote:One would be better off with a rewrite ,I think, rather than doing a complete refactoringAt least for a rewrite there is the vega strike code and decent freespace 2 code to use as a template on ways to (and not to) do things.
-
- Expert Mercenary
- Posts: 893
- Joined: Thu Jul 08, 2010 11:43 pm
- Location: Sol III North American Continent
Re: Laughable code comment of the day
May have to check it out.
Anything that VS could offer in the way of a partnership? It is opensource, so could just credit them and lift the parts useful to our little game, but would be better if we could offer something in return.Deus Siddis wrote:shows much promise in areas VS always dreamed about
-
- Elite
- Posts: 7243
- Joined: Mon Apr 18, 2005 2:40 pm
- Location: LS87, Buenos Aires, República Argentina
Re: Laughable code comment of the day
In return (or not) they can pull out whatever code they want.
That's the OSS way anyway.
That's the OSS way anyway.
-
- Expert Mercenary
- Posts: 893
- Joined: Thu Jul 08, 2010 11:43 pm
- Location: Sol III North American Continent
Re: Laughable code comment of the day
I was A not wanting to step on any toes, and B thinking a partner project or mutual aid kind of thing. But, if they can do something we can't as both are open source projects grab and run!! The nice way is my usual starting point.
-
- Elite
- Posts: 7243
- Joined: Mon Apr 18, 2005 2:40 pm
- Location: LS87, Buenos Aires, República Argentina
Re: Laughable code comment of the day
Grab and run is the nice way.
If there are commonalities among the projects, cooperation may ensue, but I'm not entirely sure that is the case. There's a high degree of specificity required in order to share software components. In any case, if I grab something from a project and see an oportunity to fork that something into a library so that we can both develop that part together, that should be done.
In essence, it's grab, run... maybe return with a gift.
If there are commonalities among the projects, cooperation may ensue, but I'm not entirely sure that is the case. There's a high degree of specificity required in order to share software components. In any case, if I grab something from a project and see an oportunity to fork that something into a library so that we can both develop that part together, that should be done.
In essence, it's grab, run... maybe return with a gift.
-
- Expert Mercenary
- Posts: 893
- Joined: Thu Jul 08, 2010 11:43 pm
- Location: Sol III North American Continent
Re: Laughable code comment of the day
If nothing else seeing how something that is lacking here is done elsewhere should help, I would think.
-
- Elite
- Posts: 7243
- Joined: Mon Apr 18, 2005 2:40 pm
- Location: LS87, Buenos Aires, República Argentina
Re: Laughable code comment of the day
I would like to mention, that the new sound system (which I've called SUCSS) is modular enough to be forkable.
I haven't forked it because it entails a bit of extra effort in order to fully divorce its code from VS code (it shares a few helper classes), but it was always my intention to fork it as soon as it's mature enough.
So, if any project (not just Pioneer) is in need of an extensible and modular sound system, they should express interest in SUCSS, for if there is interest I can invest some effort into forking it sooner.
I haven't forked it because it entails a bit of extra effort in order to fully divorce its code from VS code (it shares a few helper classes), but it was always my intention to fork it as soon as it's mature enough.
So, if any project (not just Pioneer) is in need of an extensible and modular sound system, they should express interest in SUCSS, for if there is interest I can invest some effort into forking it sooner.
-
- The Shepherd
- Posts: 5841
- Joined: Fri May 13, 2005 8:37 pm
- Location: Ottawa
- Contact:
Re: Laughable code comment of the day
I downloaded it yesterday
It seems to be OGRE based and they use Lua as their scripting language I don't much like there control paradigm yet though there auto-pilot is nice,do like the their landing/takeoff animations.
Enjoy the Choice![Smile :)](./images/smilies/icon_smile.gif)
![Smile :)](./images/smilies/icon_smile.gif)
Enjoy the Choice
![Smile :)](./images/smilies/icon_smile.gif)
my box::HP Envy i5-6400 @2Q70GHzx4 8 Gb ram/1 Tb(Win10 64)/3 Tb Mint 19.2/GTX745 4Gb acer S243HL K222HQL
Q8200/Asus P5QDLX/8 Gb ram/WD 2Tb 2-500 G HD/GF GT640 2Gb Mint 17.3 64 bit Win 10 32 bit acer and Lenovo ideapad 320-15ARB Win 10/Mint 19.2
Q8200/Asus P5QDLX/8 Gb ram/WD 2Tb 2-500 G HD/GF GT640 2Gb Mint 17.3 64 bit Win 10 32 bit acer and Lenovo ideapad 320-15ARB Win 10/Mint 19.2
-
- Elite
- Posts: 1567
- Joined: Tue Jan 26, 2010 2:03 am
Re: Laughable code comment of the day
Then you might as well create a new SF project. Thats how the GiGi gui for/from freeorion was done. I don't remember the full history off hand but it was either designed for freeorion or from it, but in either case it is a seperate project on sourceforge.klauss wrote: So, if any project (not just Pioneer) is in need of an extensible and modular sound system, they should express interest in SUCSS, for if there is interest I can invest some effort into forking it sooner.
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
-
- Elite
- Posts: 7243
- Joined: Mon Apr 18, 2005 2:40 pm
- Location: LS87, Buenos Aires, República Argentina
Re: Laughable code comment of the day
I know, with fork i mean that. It's just an amount of work I'm not ready to invest yet in its infantile form to get it independent, and a commitment to interface stability i cannot guarantee just yet.