Page 2 of 2

Re: Strange OpenAL error

Posted: Tue Apr 10, 2012 4:14 pm
by klauss
I'll try to upload the cleanup patches to the reviewboard so that we can take a better look at them.

Big commits like these should go through the review board first, I'm thinking.

Re: Strange OpenAL error

Posted: Tue Apr 10, 2012 5:53 pm
by pheonixstorm
After reviewing that part of the code I can start to see a pattern on why it did not affect windows. There are far too many sections where I see #ifdef win32 code... #else linux code. A review would help but how much? With all the dead code that doesn't appear to do anything or a lot of commented out code its hard to tell what really works and what doesn't.

Re: Strange OpenAL error

Posted: Tue Apr 10, 2012 6:05 pm
by klauss
Don't worry, for 0.5.2 the Muzak class will be re-implemented to use SUCSS, so none of that code will survive.

Re: Strange OpenAL error

Posted: Tue Apr 10, 2012 6:26 pm
by pheonixstorm
yippie! :lol:

Re: Strange OpenAL error

Posted: Wed Apr 11, 2012 2:17 am
by klauss
pheonixstorm wrote:uploaded the corrected file. Makes me wonder if there are any other platform specific bugs that didn't show up in windows but have shown up in linux.
Ok, I just merged it on the 0.5.1 branch, pushed the diffs to the build service, and am awaiting for the build bots to finish. People should be getting the update shortly.

As I said, I'll wait a bit to update the tarball.

Re: Strange OpenAL error

Posted: Wed Apr 11, 2012 10:38 am
by STEVE555
Hi all,
I downloaded the latest revision and re-compiled. The great news is that music is back. The added bonus is that it seems to sound even better than it did before! I want to thank all who fixed the problem.

Regards,
STEVE555