A little change in dynamic_mission.py

[CoD]

First of all: I'm not sure if this is the right section for this thread, so if it's not please excuse me

I made a little change in vegastrike/modules/dynamic_mission.py and I would like to share it with you.

Quite often different cargo mission point at the same destination system, so it's possible to make some big money with just 1 good travel.
But.. with the listing system used in the mission computer it's not easy to figure out what of these mutilple travels is the most profitable, so I modified dynamic_mission.py in order to have cargo missions listed with the destination system first, then the type of cargo (contraband or normal cargo)

This is what I changed: in line 403, instead of

Code: Select all

writemissionname("Cargo/Deliver_%s_to_%s"%(changecat(category),processSystem(path[-1])),path,isFixerString(addstr))

I wrote:

Code: Select all

writemissionname("Cargo/%s_(%s)"%(processSystem(path[-1]),changecat(category)),path,isFixerString(addstr))

This makes mission computer list cargo mission alphabetically using destination system, making easy to see missions sharing the same target.

Hope this would be useful for someone

[rockstar]

Well, sounds good to me, makes sense to me... thumbs up

[rigelan]

I like the idea.

BTW, is there a way ingame to reference the quickest path to take to a system BEFORE choosing a mission. As of now, the quickest path shows up after you get off the planet or base.

[Oblivion]

Nifty.

Thank you for sharing the code.

BTW: Any plans in sharing this change via SVN? It's just a minor change but it would help clean up the cluttered VS interface a lot.

assuming it has no adverse effects.

[CoD]

I posted this change here because I wanted to test it with you.

I'm still trying to compile the svn version of vegastrike, with no success.
This change was tested on my old vegastrike 0.4.3.2 (ubuntu version), so I need your help, guys, to test it with a development version of vs.

If this change is safe and you guys like it I could commit it to svn but.... ehm... never done it before.
I can download the new sources, but I can't compile them and I don't know how to commit changes.
I'm always happy to learn something new, so I could try to do it, but I would need a quick little guide about committing files and comments to svn.

Maybe, until I won't be able to compile correctly, it would be easier and safer if you commit my changes for me, wouldn't it?

[klauss]

Well, it needs a fresh paint before commiting.

<destination> <cargo> is not a very pleasant description.

Perhaps "Delivery to <destination> (<cargo>)".

[CoD]

I suppose that the alphabetical order will be preserved if we write "delivery to <destination>", so it's ok.

I use the simplest way because I like to see where I should go, instead of reading "Deliver cargo to....": long sentences are always cut, and the differences between some system names are made just of 2 or 3 letters.

Mission computer interface could be more "friendly" or more "quick and dirty"... depends on taste, I think.
I'm for the quick and dirty way, but this is just my opinion: I like old, rusty computers, laying in dark corners of old bases on some forgotten asteroid, with their old crackling hard disks, their mouse-bitten cables and the old not friendly interface that welcomes you flickering on the dirty screen
Smells like good business to me

[Oblivion]

And while you're at it, could you also modify the Bounty and Escort missions to be listed alphabetically. Destinations will always have to be first, of course.

alphabetically it would be Bounty missions first ("Bounty in <destination>, Target: <ship>", or somesuch better wording with same order)

then Escort missions ("Escort to <destination>, <ship>", again needs better wording)

and last Cargo missions (as Klauss suggested "Delivery to <destination>, <cargo>")

And I like friendly computers. I sleep with mine, bathe with mine, eat with mine, my computer is my bestfriend. I've even given her a voice, now when I make a mistake, she berates me by saying gently "Unrecoverable Error". And she soothes me by saying "Systems on-line" and "Welcome Oblivion!" when I log on. Oh.. And I think I'll marry her someday.

lol.

'Sides, rusty old computers could give you tetanus.

[CoD]

And while you're at it, could you also modify the Bounty and Escort missions to be listed alphabetically. Destinations will always have to be first, of course.

I could modify this file but.. can you test it in your development version? Because (as I said) I can't

'Sides, rusty old computers could give you tetanus.

Yes but... it's not me that sleeps with his computer: I just "use" them

[Oblivion]

I could modify this file but.. can you test it in your development version? Because (as I said) I can't

I've no idea how to access SVN too. But Klauss, Zeog, or any of the coredevs could.

I'm using Zeog's SVN snapshot, and sure I'll test them.