Patch tracker needs some love

Development directions, tasks, and features being actively implemented or pursued by the development team.

Patch tracker needs some love

Postby log0 » Fri Nov 09, 2012 3:58 am

I've pushed a few patches today and noticed that there are open patches that are a year old. Can they be reviewed, applied or rejected eventually?

What is the preferred way to contribute atm, the review board thingy seems to be gone/broken?
log0
 

Share On:

Share on Facebook Facebook Share on Twitter Twitter Share on Digg Digg

Re: Patch tracker needs some love

Postby klauss » Fri Nov 09, 2012 9:55 am

The server accident wiped the review board, and in any case the patch tracker is the way.

Old patches will probably be inapplicable currently. Though they have to be reviewed. I had reviewed some a while ago.

Any one in particular you have in mind?
Oíd mortales, el grito sagrado...
Call me "Menes, lord of Cats"
Wing Commander Universe
User avatar
klauss
Elite
Elite
 
Posts: 7243
Topics: 55
Joined: Mon Apr 18, 2005 7:40 am
Location: LS87, Buenos Aires, República Argentina

Re: Patch tracker needs some love

Postby log0 » Fri Nov 09, 2012 12:34 pm

I think the outdated ones should be rejected. The gravity patch can be closed too, as it is "let's say very incomplete", should be developed in a branch maybe.

There are a few minimal ones, that shouldn't anything like the min/max cleanup. I can push updated versions btw.

I am testing with mingw/gcc, vs2010, would be great if @phoenixstorm could test them with vs2008 of course.
log0
 

Re: Patch tracker needs some love

Postby pheonixstorm » Sun Nov 11, 2012 8:24 pm

I and my branch have fallen a bit behind in everything :lol: though I did get a new binary up about tenish commits ago.
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
User avatar
pheonixstorm
Elite
Elite
 
Posts: 1567
Topics: 113
Joined: Mon Jan 25, 2010 7:03 pm

Re: Patch tracker needs some love

Postby loki1950 » Tue Sep 03, 2013 12:02 pm

That and the windows version is now only available as a 64 bit binary,I am using the last 32 bit version.

Enjoy the Choice :)
my box::HP Envy i5-6400 @2Q70GHzx4 8 Gb ram/1 Tb(Win10 64)/3 Tb Mint 18/GTX745 4Gb acer S243HL K222HQL
Q8200/Asus P5QDLX/8 Gb ram/WD 2Tb 2-500 G HD/GF GT640 2Gb Mint 17.3 64 bit Win 10 32 bit acer and DELL E6400 4GB ram/100 GB HD Mint 17.3 6
User avatar
loki1950
The Shepherd
 
Posts: 5705
Topics: 51
Joined: Fri May 13, 2005 1:37 pm
Location: Ottawa

Re: Patch tracker needs some love

Postby mohsin123 » Mon Oct 28, 2013 3:37 am

That and the windows version is now only available as a 64 bit binary,I am using the last 32 bit version.
If want to learn web designing then join E10-001 dumps web design course and download free COMPTIA tutorials and University of California, Los Angeles demos to learn how to create amazing background patterns for your web project. Best of luck,
mohsin123
Insys Pilot
Insys Pilot
 
Posts: 2
Joined: Mon Oct 28, 2013 3:36 am

Re: Patch tracker needs some love

Postby TBeholder » Tue Oct 29, 2013 1:32 am

Speaking of the tracker, this was " closed-accepted" at a testing version (before "MinWarp_05_1.diff" with fixed headers and improved functions).
"Two Eyes Good, Eleven Eyes Better." -Michele Carter
User avatar
TBeholder
Elite Venturer
Elite Venturer
 
Posts: 732
Topics: 38
Joined: Fri Apr 14, 2006 7:40 pm
Location: chthonic safety

Re: Patch tracker needs some love

Postby loki1950 » Tue Oct 29, 2013 12:13 pm

That looks like a good patch TB and any clean up is good 8)

Enjoy the Choice :)
my box::HP Envy i5-6400 @2Q70GHzx4 8 Gb ram/1 Tb(Win10 64)/3 Tb Mint 18/GTX745 4Gb acer S243HL K222HQL
Q8200/Asus P5QDLX/8 Gb ram/WD 2Tb 2-500 G HD/GF GT640 2Gb Mint 17.3 64 bit Win 10 32 bit acer and DELL E6400 4GB ram/100 GB HD Mint 17.3 6
User avatar
loki1950
The Shepherd
 
Posts: 5705
Topics: 51
Joined: Fri May 13, 2005 1:37 pm
Location: Ottawa

Re: Patch tracker needs some love

Postby pheonixstorm » Thu Oct 31, 2013 12:11 am

mohsin123 wrote:That and the windows version is now only available as a 64 bit binary,I am using the last 32 bit version.

Don't know where you heard that from but we don't even HAVE a 64bit binary yet.
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
User avatar
pheonixstorm
Elite
Elite
 
Posts: 1567
Topics: 113
Joined: Mon Jan 25, 2010 7:03 pm

Re: Patch tracker needs some love

Postby loki1950 » Thu Oct 31, 2013 1:32 am

That's xNormal that is only 64 bit now :wink: And I deleted a spammers post that was in here so the context of thread is a bit screwed up :oops:

Enjoy the Choice :)
my box::HP Envy i5-6400 @2Q70GHzx4 8 Gb ram/1 Tb(Win10 64)/3 Tb Mint 18/GTX745 4Gb acer S243HL K222HQL
Q8200/Asus P5QDLX/8 Gb ram/WD 2Tb 2-500 G HD/GF GT640 2Gb Mint 17.3 64 bit Win 10 32 bit acer and DELL E6400 4GB ram/100 GB HD Mint 17.3 6
User avatar
loki1950
The Shepherd
 
Posts: 5705
Topics: 51
Joined: Fri May 13, 2005 1:37 pm
Location: Ottawa

Re: Patch tracker needs some love

Postby pheonixstorm » Thu Oct 31, 2013 1:55 pm

damn spammers... :lol:
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
User avatar
pheonixstorm
Elite
Elite
 
Posts: 1567
Topics: 113
Joined: Mon Jan 25, 2010 7:03 pm

Re: Patch tracker needs some love

Postby klauss » Tue Dec 03, 2013 10:08 am

TBeholder wrote:Speaking of the tracker, this was " closed-accepted" at a testing version (before "MinWarp_05_1.diff" with fixed headers and improved functions).


I thought I had committed MinWrap_05_1.diff. I guess I thought wrong.

Can you re-open the ticket?
Oíd mortales, el grito sagrado...
Call me "Menes, lord of Cats"
Wing Commander Universe
User avatar
klauss
Elite
Elite
 
Posts: 7243
Topics: 55
Joined: Mon Apr 18, 2005 7:40 am
Location: LS87, Buenos Aires, República Argentina

Re: Patch tracker needs some love

Postby TBeholder » Tue Dec 03, 2013 11:31 am

The last one has ExpectAutoRampdownTime(...) and EnergyWarrantsWarp(...) in warpto.cpp - if these functions aren't here, it wasn't included.
I can't change status of anything. Or even tags on my own tickets (which is more annoying).
"Two Eyes Good, Eleven Eyes Better." -Michele Carter
User avatar
TBeholder
Elite Venturer
Elite Venturer
 
Posts: 732
Topics: 38
Joined: Fri Apr 14, 2006 7:40 pm
Location: chthonic safety

Re: Patch tracker needs some love

Postby klauss » Tue Dec 03, 2013 1:54 pm

It seems I have no way to give permissions to the ticket author, it's either all users in a group or nothing :(

Anyway, in those cases, you can post a comment asking for it to be reopened I guess.

I already reopened.
Oíd mortales, el grito sagrado...
Call me "Menes, lord of Cats"
Wing Commander Universe
User avatar
klauss
Elite
Elite
 
Posts: 7243
Topics: 55
Joined: Mon Apr 18, 2005 7:40 am
Location: LS87, Buenos Aires, República Argentina



Return to Engine Development

Who is online

Users browsing this forum: No registered users and 2 guests

cron