Newcomer with a few patches

Development directions, tasks, and features being actively implemented or pursued by the development team.

Re: Newcomer with a few patches

Postby klauss » Sat Jul 13, 2013 1:18 pm

Which ones do you see still relevant to trunk? (AFAIR, I had reviewed and merged quite a few)
Oíd mortales, el grito sagrado...
Call me "Menes, lord of Cats"
Wing Commander Universe
User avatar
klauss
Elite
Elite
 
Posts: 7243
Topics: 55
Joined: Mon Apr 18, 2005 7:40 am
Location: LS87, Buenos Aires, República Argentina

Share On:

Share on Facebook Facebook Share on Twitter Twitter Share on Digg Digg

Re: Newcomer with a few patches

Postby vincele » Sat Jul 13, 2013 4:07 pm

patch 15
http://sourceforge.net/p/vegastrike/pat ... ref-1.diff
still looks applicable with a 1 line offset but which is arguably of gret value, but still...

and I thought patches from #26 were, but they are no more relevant

So thank you for applying my previous batch, I may still continue to send that kind of small fixes, and maybe more, c.f.
viewtopic.php?f=21&t=18591
vincele
Merchant
Merchant
 
Posts: 35
Topics: 6
Joined: Mon Jul 04, 2011 10:32 am

Re: Newcomer with a few patches

Postby vincele » Sat Jul 13, 2013 4:16 pm

and patches 9 & 12 needed more work, so, I'll get back to them too...
vincele
Merchant
Merchant
 
Posts: 35
Topics: 6
Joined: Mon Jul 04, 2011 10:32 am

Re: Newcomer with a few patches

Postby klauss » Sat Jul 13, 2013 5:31 pm

vincele wrote:patch 15
http://sourceforge.net/p/vegastrike/pat ... ref-1.diff
still looks applicable with a 1 line offset but which is arguably of gret value, but still...


Ok, committed.
Oíd mortales, el grito sagrado...
Call me "Menes, lord of Cats"
Wing Commander Universe
User avatar
klauss
Elite
Elite
 
Posts: 7243
Topics: 55
Joined: Mon Apr 18, 2005 7:40 am
Location: LS87, Buenos Aires, República Argentina

Re: Newcomer with a few patches

Postby pheonixstorm » Sat Jul 13, 2013 9:26 pm

Most of the latest work was getting py3 working with the engine before merging with trunk. Most work is back to trunk I think, though I would like to revive my old branch for some tinkering and profiling.
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
User avatar
pheonixstorm
Elite
Elite
 
Posts: 1567
Topics: 113
Joined: Mon Jan 25, 2010 7:03 pm

Re: Newcomer with a few patches

Postby vincele » Sun Jul 14, 2013 12:59 pm

OK good to know.

I've got a new batch of smallish cleanups and fixes, mainly for data/modules python files, but what I found made me ask if all that is still in real use, because there's real bugs in there... For example, is spectre.py used at all ?

What do I do with that batch as I cannot use SF.net currently, and I don't know how to fix that, maybe create a new account...
vincele
Merchant
Merchant
 
Posts: 35
Topics: 6
Joined: Mon Jul 04, 2011 10:32 am

Re: Newcomer with a few patches

Postby vincele » Sun Jul 14, 2013 1:57 pm

OK SF.net back working properly, so small fixes batch is here :
https://sourceforge.net/p/vegastrike/patches/59/ and here
https://sourceforge.net/p/vegastrike/patches/60/

How can I be marked "owner" of those bug reports ? And maybe the 9, 12, 15 & 26 ones too...
vincele
Merchant
Merchant
 
Posts: 35
Topics: 6
Joined: Mon Jul 04, 2011 10:32 am

Re: Newcomer with a few patches

Postby klauss » Mon Jul 15, 2013 12:38 pm

vincele wrote:OK SF.net back working properly, so small fixes batch is here :
https://sourceforge.net/p/vegastrike/patches/59/ and here
https://sourceforge.net/p/vegastrike/patches/60/

How can I be marked "owner" of those bug reports ? And maybe the 9, 12, 15 & 26 ones too...


I've been seeing those patch tracker mails pile up lately. Sorry for the delay, but I've been sick. As soon as I'm able I'll start reviewing them.
Oíd mortales, el grito sagrado...
Call me "Menes, lord of Cats"
Wing Commander Universe
User avatar
klauss
Elite
Elite
 
Posts: 7243
Topics: 55
Joined: Mon Apr 18, 2005 7:40 am
Location: LS87, Buenos Aires, República Argentina

Re: Newcomer with a few patches

Postby vincele » Mon Jul 15, 2013 1:09 pm

No problem, I'll just continue to pile up on those, and already have added two more...

Do you agree with the granularity or is it split too much ?
I like very small independent things, I think it's easier to review/apply...
vincele
Merchant
Merchant
 
Posts: 35
Topics: 6
Joined: Mon Jul 04, 2011 10:32 am

Re: Newcomer with a few patches

Postby klauss » Mon Jul 15, 2013 5:08 pm

vincele wrote:No problem, I'll just continue to pile up on those, and already have added two more...

Do you agree with the granularity or is it split too much ?
I like very small independent things, I think it's easier to review/apply...


I haven't seen them yet, but in general, the more they're split the better, as long as all related changes are on the same patch (ie: one atomic fix per patch, no more, no less). So, if you fixed an expression that is used in 5 places, you'd fix those 5 places in one patch, rather than 5 patches.
Oíd mortales, el grito sagrado...
Call me "Menes, lord of Cats"
Wing Commander Universe
User avatar
klauss
Elite
Elite
 
Posts: 7243
Topics: 55
Joined: Mon Apr 18, 2005 7:40 am
Location: LS87, Buenos Aires, República Argentina


Previous

Return to Engine Development

Who is online

Users browsing this forum: No registered users and 1 guest

cron