Page 1 of 1

Reviews via Codestriker

Posted: Fri Dec 24, 2010 1:31 pm
by breese
If we are in need of a review tool, then SourceForge provides the Codestriker tool for us.

I have only used Review Board, so I am not familiar with Codestriker, but it looks promising.

Somebody with administration rights have to add this feature. This is done by selecting "Features" from the "Project Admin" menu, switch to the "Available Features" tab, and enable Codestriker.

Re: Reviews via Codestriker

Posted: Fri Dec 24, 2010 4:42 pm
by klauss
I just tried and no, I don't have administrative rights.

I can admin the bug tracker, but not the whole project.

Bummer, because we do need a review board of sorts...

Re: Reviews via Codestriker

Posted: Fri Dec 24, 2010 4:52 pm
by charlieg
Or just have a code review board here on phpbb?

Re: Reviews via Codestriker

Posted: Fri Dec 24, 2010 10:54 pm
by pheonixstorm
Well, I sent an email to ace asking for more project permissions or possible project admin status for myself or klauss. Still have not heard anything about it yet.

Worst case scenerio is we fork development of VS into a new sf project so that we have far greater control over everything with no more waiting on ace or the others to setup new svn access or file permissions etc.

Re: Reviews via Codestriker

Posted: Sun Dec 26, 2010 3:47 am
by charlieg
Forks are healthy.

http://sourceforge.net/projects/glest
http://sourceforge.net/projects/glestae

Do it. Even if it only ends up being temporary, it serves a purpose.

Re: Reviews via Codestriker

Posted: Tue Dec 28, 2010 4:16 am
by klauss
The thing with forking is that VS has a HUGE repo, way over sourceforge's soft limit.

We've been graced by SF.net since the project really makes use of this data, but forking might be frowned upon (duplicating data on SF.net servers).

We're better off asking for administrative access to SF.net (they can gran us access if the project admins don't respond), but I bet they'll respond.

Did you try contacting hellcatv?

Re: Reviews via Codestriker

Posted: Tue Dec 28, 2010 6:29 am
by pheonixstorm
No, just ace who has been the most recent admin to stop by. Its in the release thread he dropped me his email to ask about what I needed but thats been awhile.

If we did fork.. I think we could always host the source on the fork as well as the releases but use an external to the data on this svn.

Re: Reviews via Codestriker

Posted: Tue Dec 28, 2010 7:28 am
by Deus Siddis
klauss wrote: We're better off asking for administrative access to SF.net (they can gran us access if the project admins don't respond), but I bet they'll respond.

Did you try contacting hellcatv?
Of all of us you have been around the longest and are the most well known. You should request from him project admin rights for yourself.

Re: Reviews via Codestriker

Posted: Tue Dec 28, 2010 12:29 pm
by charlieg
1. Friendly forks are good; healthy. Git - everything is a fork. ;)

2. SF.net data usage by VS is immense because of the way VS uses SVN (i.e. the history). An import of the current SVN would not be particularly burdensome. Even so, I can't imagine a fork containing anything other than what is necessary, so probably just the source for now with data being kept back in VS SVN.

Re: Reviews via Codestriker

Posted: Tue Dec 28, 2010 4:19 pm
by klauss
Ok, hold your horses people. No need to fork.

I'm not saying forking is bad, only burdensome.

I'll contact Daniel.

Re: Reviews via Codestriker

Posted: Tue Dec 28, 2010 6:29 pm
by charlieg
Nothing wrong with forking though. :P

Just create a github account, upload changes there. It's technically a fork. You might consider each branch in SVN to be a fork. It depends upon what you consider to be a fork. A distinct project with different goals that competes with the original? Or just an alternative codebase used to spur development of different features in a concurrent manner? Or a way to work around old administration issues? I don't think anybody is advocating anything other than friendly forking. Forking is healthy.

Just don't say it too fast in case somebody mishears you. ;)

Re: Reviews via Codestriker

Posted: Tue Dec 28, 2010 6:37 pm
by klauss
charlieg wrote:Forking is healthy
Amen.

:p

But seriously, temporary branching can be done with gitsvn by anyone (just committing to their local repo), and I don't expect our administrative woes to last too long.