SPEC Capacitors SVN 13248

Find any bugs in Vega Strike? See if someone has already found it, or report them here!

SPEC Capacitors SVN 13248

Postby Hicks » Fri Nov 25, 2011 7:03 am

Buying or selling SPEC capacitors in a base does not seem to update the warp capacitor bank storage value. After a short flight and landing at another base it seemed to update, but after buying a new SPEC capacitor it failed to update again.
Hicks
Bounty Hunter
Bounty Hunter
 
Posts: 153
Topics: 10
Joined: Sat Oct 22, 2011 2:17 am

Share On:

Share on Facebook Facebook Share on Twitter Twitter Share on Digg Digg

Re: SPEC Capacitors SVN 13248

Postby pheonixstorm » Fri Nov 25, 2011 12:48 pm

svn trunk or my branch?
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
User avatar
pheonixstorm
Elite
Elite
 
Posts: 1567
Topics: 113
Joined: Mon Jan 25, 2010 7:03 pm

Re: SPEC Capacitors SVN 13248

Postby Hicks » Fri Nov 25, 2011 5:29 pm

trunk

edit: both actually, so i guess the problem is steming from the trunk
Hicks
Bounty Hunter
Bounty Hunter
 
Posts: 153
Topics: 10
Joined: Sat Oct 22, 2011 2:17 am

Re: SPEC Capacitors SVN 13248

Postby TBeholder » Sat Nov 26, 2011 2:12 am

The way to reproduce:
  1. Visit any base/planet and buy a non-milspec ship.
  2. Look at stats.
  3. Sell its warp cap.
  4. Look at stats. Warp capacitance decreased.
  5. Buy the warp cap back.
  6. Look at stats. Warp capacitance is not increased (unless you have "simulation while docking" turned on).
  7. Leave station, wait until warp energy bar noticeably replenishes (with speccap-1 and shield-1 on reactor-1 it's not that slow) and re-dock.
  8. Look at stats. Warp cap increased.
Answer: indication in basecomputer.cpp is messed up. It tries to use functions instead of checking fields directly. But it uses current warp energy instead of max warp energy because the coder didn't find a proper function. See also: comments.
"Two Eyes Good, Eleven Eyes Better." -Michele Carter
User avatar
TBeholder
Elite Venturer
Elite Venturer
 
Posts: 744
Topics: 38
Joined: Fri Apr 14, 2006 7:40 pm
Location: chthonic safety

Re: SPEC Capacitors SVN 13248

Postby pheonixstorm » Sat Nov 26, 2011 2:17 am

Interesting.. wonder how long its been screwy then.

We shall send a trained monkey to create a patch and pray by the seat of our pants that it works.

Knowing more or less where the naughty code is should make this easier to fix. Good catch!
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
User avatar
pheonixstorm
Elite
Elite
 
Posts: 1567
Topics: 113
Joined: Mon Jan 25, 2010 7:03 pm

Re: SPEC Capacitors SVN 13248

Postby Hicks » Sat Nov 26, 2011 2:30 am

I found out by starting a new game. When you sell the capacitor on the llama, the value doesn't go down.
Hicks
Bounty Hunter
Bounty Hunter
 
Posts: 153
Topics: 10
Joined: Sat Oct 22, 2011 2:17 am

Re: SPEC Capacitors SVN 13248

Postby pheonixstorm » Sat Nov 26, 2011 2:34 am

Quirky. So it only goes down when you buy a new ship? That just seems... odd.
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
User avatar
pheonixstorm
Elite
Elite
 
Posts: 1567
Topics: 113
Joined: Mon Jan 25, 2010 7:03 pm

Re: SPEC Capacitors SVN 13248

Postby Hicks » Fri Dec 09, 2011 8:17 pm

shouldn't there be a function in there to find max energy? how does it determine how much of the spec energy bar it needs to fill on the interface when you are flying?
Hicks
Bounty Hunter
Bounty Hunter
 
Posts: 153
Topics: 10
Joined: Sat Oct 22, 2011 2:17 am

Re: SPEC Capacitors SVN 13248

Postby TBeholder » Mon Dec 12, 2011 12:28 pm

Hicks wrote:shouldn't there be a function in there to find max energy? how does it determine how much of the spec energy bar it needs to fill on the interface when you are flying?
Maybe, but it's done simply by reading the field maxwarpenergy itself.
Warp gauge shows ->WarpEnergyData(), which if maxwarpenergy>0 is warpenergy/maxwarpenergy, otherwise if jump.energy > 0, warpenergy/jump.energy, and failed that, 0.
"Two Eyes Good, Eleven Eyes Better." -Michele Carter
User avatar
TBeholder
Elite Venturer
Elite Venturer
 
Posts: 744
Topics: 38
Joined: Fri Apr 14, 2006 7:40 pm
Location: chthonic safety



Return to Bug Triage

Who is online

Users browsing this forum: No registered users and 5 guests

cron