No sensors on sale in SVN

Find any bugs in Vega Strike? See if someone has already found it, or report them here!

No sensors on sale in SVN

Postby echoes91 » Fri Apr 01, 2011 9:01 am

Hello, I compiled and tried the SVN under Linux some days ago and I noticed that sensors can't be found anywhere in the whole universe ( :roll: ok... in all the systems I visited) , even after generating a new one. Today I upgraded to rev. 13178 and they still don't appear, so I asked myself if it was wanted or not... Anyway, the Skyscope Alpha is still provided with any new ship, so the bug regards only the updates.
echoes91
Trader
Trader
 
Posts: 23
Topics: 8
Joined: Mon Mar 07, 2011 1:50 pm

Share On:

Share on Facebook Facebook Share on Twitter Twitter Share on Digg Digg

Re: No sensors on sale in SVN

Postby klauss » Fri Apr 01, 2011 2:02 pm

Weird, I have a savegame at home that shows sensors available all over the place.

I will start a new game (in case the old savegame somehow compensates for the bug) and try to reproduce it.
Oíd mortales, el grito sagrado...
Call me "Menes, lord of Cats"
Wing Commander Universe
User avatar
klauss
Elite
Elite
 
Posts: 7243
Topics: 55
Joined: Mon Apr 18, 2005 7:40 am
Location: LS87, Buenos Aires, República Argentina

Re: No sensors on sale in SVN

Postby pyramid » Fri Apr 01, 2011 3:23 pm

We lost the required sensor categories to be available on planets with the svn revision 13165 commit of units.csv.

Now planets list:
Code: Select all
{upgrades/Sensors/Confed;1;.1;-12;17}{upgrades/Sensors/Common;1;.1;20;6}


But the sensor upgrades are in the categories:
Code: Select all
{upgrades/Sensors/Advanced;1;.1;-12;17}{upgrades/Sensors/Basic;1;.1;20;6}{upgrades/Sensors/Intermediate;1;.1;9;8}


We could revert to the previous version or better fix the upgrades sections in all planets that were changed. 16 planets were changed and many of the stations, though a quick scan didn't reveal any wrong categories on stations.

On a side note: an asset editor would be really helpful in editing units and cross checking e.g. categories.

*EDIT*
Actually, installations are affected, too. :evil:
User avatar
pyramid
Expert Mercenary
Expert Mercenary
 
Posts: 960
Topics: 44
Joined: Wed Jun 14, 2006 6:02 pm
Location: Somewhere in the vastness of space

Re: No sensors on sale in SVN

Postby pyramid » Fri Apr 01, 2011 6:14 pm

User avatar
pyramid
Expert Mercenary
Expert Mercenary
 
Posts: 960
Topics: 44
Joined: Wed Jun 14, 2006 6:02 pm
Location: Somewhere in the vastness of space

Re: No sensors on sale in SVN

Postby breese » Sat Apr 02, 2011 3:04 am

pyramid wrote:Bug tracker artifact 3267978 was created.

Something was lost in my original submission of the new radars. I reapplied that to units.csv in r13165, but unfortunately forgot to apply the same change to master_part_list.csv. I have fixed that in r13180.

You can find the rationale for the change in the reorganizing the radars thread.
breese
Bounty Hunter
Bounty Hunter
 
Posts: 152
Topics: 14
Joined: Thu Sep 02, 2010 1:00 pm

Re: No sensors on sale in SVN

Postby pyramid » Sat Apr 02, 2011 12:51 pm

Ok. I wasn't aware of the re-categorization of sensors. In this case it might be required to adapt ship_upgrades.py in order for dynamically generated units to get those upgrades, too, according to your newly devised classes.
User avatar
pyramid
Expert Mercenary
Expert Mercenary
 
Posts: 960
Topics: 44
Joined: Wed Jun 14, 2006 6:02 pm
Location: Somewhere in the vastness of space

Re: No sensors on sale in SVN

Postby echoes91 » Sun Apr 03, 2011 4:11 am

It's so good to see that after just one day there's a new rev. with the issue corrected. I've rarely seen such a fast developer's response, especially on an open source videogame. Great work guys! I'd really like to contribute but my skills are too limited for a project like this :oops:
echoes91
Trader
Trader
 
Posts: 23
Topics: 8
Joined: Mon Mar 07, 2011 1:50 pm

Re: No sensors on sale in SVN

Postby pyramid » Sun Apr 03, 2011 4:11 am

The categories in ship_upgrades.py are now aligned with the other files.
User avatar
pyramid
Expert Mercenary
Expert Mercenary
 
Posts: 960
Topics: 44
Joined: Wed Jun 14, 2006 6:02 pm
Location: Somewhere in the vastness of space



Return to Bug Triage

Who is online

Users browsing this forum: No registered users and 1 guest

cron