Duplicated exit links in bars [patch included]

Find any bugs in Vega Strike? See if someone has already found it, or report them here!
Post Reply
nikai
Trader
Trader
Posts: 18
Joined: Tue Jun 01, 2010 4:23 pm

Duplicated exit links in bars [patch included]

Post by nikai »

There's a small problem in SVN I'm trying to solve: In a number of bars the exit link is duplicated.

In bars on Ocean planets you may not immediately notice, but clicking the right mouse button repeatedly you'll see that the pointer jumps to the exit link twice as often. That's because two links are rendered in the same place.

On desert planets it's most obvious, there are two different texts rendered above each other as the Main Concourse is named Main Tent there. In an other place two exit links are rendered very close to each other, looking weird as well.

So here's an attempt to clean the duplicated links. In order to allow custom exit link text ("Main Tent"), I'm passing that text to MakeBar in bases/bar.py.
You do not have the required permissions to view the files attached to this post.
klauss
Elite
Elite
Posts: 7243
Joined: Mon Apr 18, 2005 2:40 pm
Location: LS87, Buenos Aires, República Argentina

Re: Duplicated exit links in bars [patch included]

Post by klauss »

Seems like a sensible patch.

Sadly I can't test it ATM, being at work.
But I can commit it. Seems to make sense while reading the patch, so I trust my instincts ;)

I'll test it when I get home.
Oíd mortales, el grito sagrado...
Call me "Menes, lord of Cats"
Wing Commander Universe
Post Reply