Diplomatic_CenterAgricultural_Station Not Found Fix

[whraven]

After hitting this problem, also reported in another thread (http://vegastrike.sourceforge.net/forum ... =2&t=10428), in several systems, I dug through the code and found a missing comma in units/faction_ships.py. Patch is attached, but faction_ships.pyc will need to be recompiled. I do have a version recompiled with python 2.4 (yes, I need to update my system) if anyone needs it.

I do believe, due to some indexing issues that it may break existing save-files, but I haven't tested it with an old save-file.

[loki1950]

So it wasn't a missing comma in units.csv this time but a misplaced one in the Python this time.

Enjoy the Choice

[ace123]

I committed your change. Good catch--in fact I didn't realize that python let you do string concatenation like that.

[whatch1]

Close but no Cigar

Just tested the fix

unless 2 agracultural stations named "Agracultural station Agracultural station" with no Diplomatic Center was the desired result.

[whraven]

2 agracultural stations named "Agracultural station Agracultural station" with no Diplomatic Center was the desired result.

Is this with an old save file? I believe the fix will cause an index conflict with old save files. I've tried it with a brand new game without seeing the problem you mentioned so far.

[whatch1]

I was afraid that would if i used the my old save file

i was looking for a fix saw the your post, brought down the latest svn with your fix and started a fresh campain that is when i saw the "agracurlural station agracurlural station" at two different places in the system.


Bill

[loki1950]

Did you also clean out all the stuff in the .vegastrike folder before starting that new game that's something that i have been doing for a couple of years now whenever i test a new change as the generated files kept there can conflict with the new data or code.

Enjoy the Choice

[whraven]

Did you also clean out all the stuff in the .vegastrike folder before starting that new game ...

Wouldn't surprise me if that was part of the problem. There is a lot of generated stuff in the sectors and serialized.xml folder that have referents to outside data structures. When those structures change, the referents break.

Now, I'm not sure this is the case. I just haven't seen it yet with a fully clean .vegastrike folder after the change. If I do, I'll certainly try to track it down.