wingmen + flightgroup directive "k"

Find any bugs in Vega Strike? See if someone has already found it, or report them here!
Post Reply
jacs
Explorer
Explorer
Posts: 11
Joined: Thu Aug 28, 2008 6:43 am

wingmen + flightgroup directive "k"

Post by jacs »

This is an awesome project and thanks for all the work.
Now playing VS for a couple of hours I stumbled upon a problem with those cargo wingmen who would simply refuse to give up their freedom and allow themselves to be tractored back in. I can't really blame them, but still ... .
Anyway, looking aroung in the wiki, forum and finally in the source code I might just as well share what I found out.

The Wingmen Problem
catching a fighter with tractor beam mounted on a mule is kind of impossible
but then, there is vegastrike.config and the possibility to add
[code] <bind key="X" modifier="none" command="CommDockWithMe"/> [/code]
unfortunately ... it doesn't work (well they get the message right but they rather buzz off into space)
took me some time but I guess that's why
[code]LeadMe ("g","Get in front of me and prepare to be tractored in.", false);[/code]
should probably be
[code]LeadMe ("l","Get in front of me and prepare to be tractored in.", false);[/code]
/trunk/vegastrike/src/cmd/ai/firekeyboard.cpp, Revision 12353, Line 780
(sorry no patch yet because I have absolutely no idea what I'm doing... :-) )

Looking through the code, I also stumbled on something that might be a tiny bug: The K, k problem for flightgroup directives:
/trunk/vegastrike/src/cmd/ai/aggressive.cpp , Revision 12381 , Line 660
[code]if (fg->directive.find("k")!=string::npos||fg->directive.find("k")!=string::npos) {[/code]
should be ??
[code]
if (fg->directive.find("k")!=string::npos||fg->directive.find("K")!=string::npos) {[/code]
just because all the other directives use that capital letter thing for priorities ...
pyramid
Expert Mercenary
Expert Mercenary
Posts: 988
Joined: Thu Jun 15, 2006 1:02 am
Location: Somewhere in the vastness of space
Contact:

Re: wingmen + flightgroup directive "k"

Post by pyramid »

Welcome jacs. Thanks for tracking down the sources of the problems.

Re wingmen. Do you know what the first variable in LeadMe is for? What functions are represented by "g" and "l"?

Re flightgroup. Sounds feasible. I'll have a look into that later.
jacs
Explorer
Explorer
Posts: 11
Joined: Thu Aug 28, 2008 6:43 am

Post by jacs »

Hi pyramid,
now that was really quick.
about the first letter
It's just that - the flightgroup directive :-)
you might want to have a look on another thread I posted (I split them up because they were kind of a different topic:
http://vegastrike.sourceforge.net/forum ... hp?t=12030

Apparently the L or l directive is the one that makes the cargo wingmen play sitting duck in front of the ship.

[edit]
I haven't found a single reference to g (and I really tried...)
[/edit]
pyramid
Expert Mercenary
Expert Mercenary
Posts: 988
Joined: Thu Jun 15, 2006 1:02 am
Location: Somewhere in the vastness of space
Contact:

Post by pyramid »

I saw only after posting that you had another topic. Did you actually recompile vegastrike with the "l" directive and test if it actually solves the problem?
pyramid
Expert Mercenary
Expert Mercenary
Posts: 988
Joined: Thu Jun 15, 2006 1:02 am
Location: Somewhere in the vastness of space
Contact:

wingmen + flightgroup directive "k" [SOLVED]

Post by pyramid »

The fix is committed to svn.
jacs
Explorer
Explorer
Posts: 11
Joined: Thu Aug 28, 2008 6:43 am

Post by jacs »

Sorry but I didn't get to recompile it yet, that's why I didn't post it in the bug tracker. I probably will do it this week to check it out, though.
jacs
Explorer
Explorer
Posts: 11
Joined: Thu Aug 28, 2008 6:43 am

Post by jacs »

just recompiled it with current version in svn and it seems to work like a charm (the l directive - don't have a test case for k though). Thanks pyramid for that quick svn update.
pyramid
Expert Mercenary
Expert Mercenary
Posts: 988
Joined: Thu Jun 15, 2006 1:02 am
Location: Somewhere in the vastness of space
Contact:

Post by pyramid »

You're welcome.

Glad it works out :D
Post Reply