The hidden console application in Galaxy_gen.cpp

[ezee]

I was surprised to find that application in the Vegastrike project :
Standalone StarSystem generator

It must be activated by a preprocessor define , so i've tested it because it seems to be
a precious tool . But it is broken , there were errors that i have fixed easily , like ' ; ' instead of ' , ' , and missing separator between arguments .
BUt i have a var that is missing , and that i can't replace .
Perhaps you will know something about that hidden main(...) fonction :

#ifdef CONSOLE_APP
int main( int argc, char **argv )
{
if (argc < 9) {
VSFileSystem::vs_fprintf(
stderr,
"Usage: starsysgen <seed> <sector>/<system> <sunradius>/<compactness> <numstars> [N][A]<numnaturalphenomena> <numstarbases> <faction> <namelist> [OtherSystemJumpNodes]...\n" );
return 1;
}
int seed;
if ( 1 != sscanf( argv[1], "%d", &seed ) )
return 1;
string sectorname( getStarSystemSector( argv[2] ) );
string filen( getStarSystemFileName( argv[2] ) );
string systemname = string( getStarSystemName( argv[2] ) );
int numbigthings;
bool nebula = true;
bool asteroid = true;
float srad;
float comp;
sscanf( argv[3], "%f/%f", &srad,&comp );
vector< string >jumps;
for (unsigned int i = 12; i < argc; i++)
jumps.push_back( string( argv ) );
if ( 1 == sscanf( argv[8], "AN%d", &numbigthings ) || 1 == sscanf( argv[8], "NA%d", &numun[0] ) )
nebula = asteroid = true;
else if ( 1 == sscanf( argv[8], "A%d", &numbigthings ) )
asteroid = true;
else if ( 1 == sscanf( argv[8], "N%d", &numbigthings ) )
nebula = true;
else if ( 1 == sscanf( argv[8], "%d", &numbigthings ) )
nebula = asteroid = true;
else
return -1;
generateStarSystem( "./",
seed,
sectorname,
systemname,
filen,
srad, comp,
strtol( argv[4], NULL, 10 ),
strtol( argv[5], NULL, 10 ),
strtol( argv[6], NULL, 10 ),
strtol( argv[7], NULL, 10 ),
nebula,
asteroid,
numbigthings,
strtol( argv[9], NULL, 10 ),
argv[10],
argv[11],
jumps );

return 0;
}

The error line is :

1>..\..\vegastrike\src\galaxy_gen.cpp(1422) : error C2065: 'numun' : undeclared identifier

I guess this is a deprecated utility function , but i don't want rip it from the source without an attempt to fix it with your help .
Thx .

[drifter]

Replace numun[0] with numbigthings

[ezee]

I will try that , but after have understood this command .
Strange comparison ...

looking to c++ doc for sscanf :

int sscanf ( const char * s, const char * format, ...);
Read formatted data from string
Reads data from s and stores them according to parameter format into the locations given by the additional arguments, as if scanf was used, but reading from s instead of the standard input (stdin).

The additional arguments should point to already allocated objects of the type specified by their corresponding format specifier within the format string.

So yeah , if i use "numbigthings" , he is of type 'int' so that should work .
But i don't fully understand what is going on .
I'll report after the test , thank you !

[ezee]

So i have tested and i have a last error that shows that this console program is obsolete,
because of this function :

generateStarSystem( "./",
seed,
sectorname,
systemname,
filen,
srad, comp,
strtol( argv[4], NULL, 10 ),
strtol( argv[5], NULL, 10 ),
strtol( argv[6], NULL, 10 ),
strtol( argv[7], NULL, 10 ),
nebula,
asteroid,
numbigthings,
strtol( argv[9], NULL, 10 ),
argv[10],
argv[11],
jumps );

The error is :

1>..\..\vegastrike\src\galaxy_gen.cpp(1448) : error C2660: 'generateStarSystem' : function does not take 18 arguments

So i went to the declaration of the function :

void generateStarSystem( SystemInfo &si );

SystemInfo :

/// All the properties from the galaxy in a system.
struct SystemInfo
{
string sector;
string name;
string filename;
float sunradius;
float compactness;
int numstars;
bool nebulae;
bool asteroids;
int numun1;
int numun2;
string faction;
string names;
string stars;
string planetlist;
string smallun;
string nebulaelist;
string asteroidslist;
string ringlist;
string backgrounds;
vector< string >jumps;
int seed;
bool force;
};

Type mismatch ...
Perhaps i could use the new function prototype that need a struct as parameter ,
but i'm not familiar with that part of vegastrike .
Wait ... it seem that the params are only unordered , so i should be able to fill a
' SystemInfo ' myself ...

I'm gonna try it now .
But if you know how to fill it right , please help ?

[ezee]

bah ... it's too complicated for me , i'm french and some shortcuts in english are black holes
for me .

I can't fill all the struct alone :

SystemInfo info ;
info.asteroids=asteroid;
info.asteroidslist=missing
info.backgrounds=missing
info.compactness=comp;
info.faction=missing
info.filename=missing
info.force=missing
info.jumps=jumps
info.name=missing
info.names=missing
info.nebulae=nebula;
info.nebulaelist=missing
info.numstars=missing
info.numun1=missing
info.numun2=missing
info.planetlist=missing
info.ringlist=missing
info.sector=missing
info.seed=seed ;
info.smallun=missing
info.stars=missing
info.sunradius=srad;

AND It's too hard to make the difference with name and names for example ...
But if tou understand the logic , try to fill the struct for me ?

The datas are :

generateStarSystem( "./",
seed,
sectorname,
systemname,
filen,
srad, comp,
strtol( argv[4], NULL, 10 ),
strtol( argv[5], NULL, 10 ),
strtol( argv[6], NULL, 10 ),
strtol( argv[7], NULL, 10 ),
nebula,
asteroid,
numbigthings,
strtol( argv[9], NULL, 10 ),
argv[10],
argv[11],
jumps );

But it might be better to use the new fonctions , i guess that console code is too old .
But the idea is cool, and i will try to make a little console program like that ,
or use a php script to create the file ?

A star system is XML format , no ?
wait ...

struct StarXML
Starsystem XML Struct For use with XML loading.

Source : http://vegastrikevo.sourceforge.net/veg ... ystem.html

I like the idea to use the browser for create such files , i will give it a try .
EDIT : I will rip that old code from the source , deprecated .

[drifter]

Ouch, I didn't look at the original code, just the snippets you've posted above, seems to be yet another piece of very dead code.

[gonzo]

It must be activated by a preprocessor define , so i've tested it because it seems to be
a precious tool .

How do you pass the argument to get it to compile?

[ezee]

Hi .
This time i used the preprocessor option in the visual studio project .
But i could just have put a " #define CONSOLE_APP " before the other main(...) function
located in main.cpp .
Edit : That probably would fail , and i would have to put some other defines myself
to hide the main(...) that VS uses....

As i said , i was surprised to find a second main() in the sources , and curious to see
if that could work . ( in a little project yes , but with that mountain of files that is VS ? )

There are a lot of other users #defined , in that big vegastrike folder , and they served
sometimes to tests .Some where never removed , and it looks like archeology sometimes
when i study line by line the sources .

That was Vincele that said to have worked as a cleaner that gave me the idea tp do the same in my forked repositery .

It is difficult to eliminate parts of a code that is an heritage from pioneers , but i guess
it's the life's process :Elimination of dead particles and Mutation to survive ( ...cause the times , they are A changin' ... like said the song )
^^

[ezee]

@drifter

Many thanks for your attention and help .
Little gift to ya : https://www.youtube.com/watch?v=oqEcFUW9Ai4

[gonzo]

"With the humble reservation that I might have misunderstood every single line written earlier in this thread..."

I somehow navigated wrong and found the second instance of this app...

vegastrike/objconv/starsystemgen/starsysgen.cpp
And it has a "#define CONSOLE_APP" stuck in there so it probably was the last one worked on of the two.

In that same folder is actually a precompiled 32-bit binary named ssg. That must be the app right there aight?

/vegastrike/objconv/starsystemgen$ file ssg
ssg: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.2.5, not stripped

It won't run for me and I don't think I have the nerves to start messing with 32-bit libraries that would be needed to try it out right now.

[ezee]

I somehow navigated wrong and found the second instance of this app...

ah ah ah ah !!
Excellent Sir !

That story start to be very funny with you Gonzo , i like it !
^^

vegastrike/objconv/starsystemgen/starsysgen.cpp
And it has a "#define CONSOLE_APP" stuck in there so it probably was the last one worked on of the two.

Again , ah ah ah ah !
I'll check that tomorrow , cool , i am a 32bit user !
Generate star systems , it's a job i'd like to try ...
Thank you Gonzo , for the fun and this 2nd chance :
I killed the first , will i save the second ?
...


Edit : Wait ... you said that you just found the declaration of the first function with
18 args on it ? I heard by instance an other main(...) Aaaaaarg ... I'll have to resurect the code i killed so ? Aaaaaargg *2 .


How much do you want to kill it for me , but nobody must know that it was a job for me.
Otherwise i'll have to kill you ( the proof ) and deny .

[gonzo]

I'll check that tomorrow , cool , i am a 32bit user !

NB. It's a linux binary.

[ezee]

Aaaaarg *3 .
This time YOU killed me .

[gonzo]

But it is broken , there were errors that i have fixed easily , like ' ; ' instead of ' , ' , and missing separator between arguments .

Where?

I lifted the whole thing out of vegastrike and went gcc on it. It eventually compiled but it dives pretty bad around:

if ( 1 == sscanf( argv[8], "AN%d", &numbigthings ) || 1 == sscanf( argv[8], "NA%d", &numun[0] ) )
nebula = asteroid = true;

I started a repo here and pushed the starsytemgen folder. Without my changes though as I went a bit unortodox yesterday.
https://github.com/zonkmachine/starsysgen

Here's another thread on generating star systems:
http://forums.vega-strike.org/viewtopic.php?f=4&t=17106

[ezee]

Where?

Launch it in your compiler , you'll see quick where .
wait ...

generateStarSystem( "./",
1433 seed,
1434 sectorname,
1435 systemname,
1436 filen,
1437 srad, comp;
1438 strtol( argv[4], NULL, 10 ),
1439 strtol( argv[5], NULL, 10 ),
1440 strtol( argv[6], NULL, 10 ),
1441 strtol( argv[7], NULL, 10 ),
1442 nebula,
1443 asteroid,
1444 numbigthings,
1445 strtol( argv[9], NULL, 10 ),
1446 argv[10],
1447 argv[11],
1448 jumps );
1449
1450 return 0;

there was an other , but i can't remember where , well hidden again .

[ezee]

i got him ( the compiler complained in this line ) :

sscanf( argv[3], "%f/%f", &srad&comp );

I tried to figure out the problem , and i've found that to solve :

sscanf( argv[3], "%f/%f", &srad,&comp );

[gonzo]

1437 srad, comp;

sscanf( argv[3], "%f/%f", &srad&comp );

None of this is in the code I'm working from. Still crashing though...

[ezee]

You've got an error msg ?

Edit : Check if the functions you use in your code are declared somewhere , because vegastrike uses a lot of headers . So if you just cut/paste a piece of code , some declarations can be missing .

But generally a compiler say something like " unknown funcgonzo() in line 2001 "
( carl ? 2001 ? mwah ah ah )

EDIT : HEY ! I'm using the sources from 0.5.1 rc1 , that's why the code may differ ...

[gonzo]

You've got an error msg ?

No, just something along the lines "I'm not happy with you - core dumped".
I'm not up to date with using a debugger so I just added a message string at random places to pin down the faulty line. The changes I did was basically including cstring and changing some integers from or to unsigned to stop the compiler from wining. These changes I left out from github.

Edit : Check if the functions you use in your code are declared somewhere , because vegastrike uses a lot of headers . So if you just cut/paste a piece of code , some declarations can be missing .

No, this is a proper stand alone app.

EDIT : HEY ! I'm using the sources from 0.5.1 rc1 , that's why the code may differ ...

I think you're still in the code in galaxy_gen.cpp. I'm in here:
https://github.com/Ezeer/VegaStrike_win ... rsystemgen

[ezee]

Aaaaa....ok !
I'm working in the market lib right now , but this is very interesting .
Thank you for showing me the direction gonzo .
( and good luck )

[ezee]

Man ! I was so curious to see ...
I have created a new project in the DevTools solution for windows,
using starsystem.cpp as source , and ....
That works !


Man this is the result i was searching , so bad i can't share it with you because of the difference of OS .
But hey , that file works fine . ( i just launched the app , not given params yet )

THANK YOU !!!


EDit : I am very happy because i was searching a way to modify vegastrike to generate some market places in his universe . I will start by modify that tool to register the bases
and their factories .
Then modify vegastrike to be able to read my new version of generated files .
That's ... fantastic !

[gonzo]

...not given params yet

I can make it run and it will ask for parameters. When I give it something to work with it crashes.
I run it by just giving it a chain of numbers like:

Code: Select all

./starsysgen 3 4 5 6 7 8 9 1

$ ./starsysgen 3 4 5 6 7 8 9 1
Segmentation fault (core dumped)

[ezee]

Perhaps in the wiki you will find the correct args to give ?
I will look up to that too .

Edit : i think i know :

"Usage: starsysgen <seed> <sector>/<system> <sunradius> <numstars> <numgasgiants> <numrockyplanets> <nummoons> [N][A]<numnaturalphenomena> <numstarbases> <faction> <namelist> [OtherSystemJumpNodes]...\n" );

first param is a real number , then 2 strings ?
The good format is in milkyway.xml in the Universe folder .
Open it and you'll see for example :

<sector name="Aantlbzz">
<system name="Aanpzezyqqh"><var name="planets" value="bsm"/>
<var name="data" value="-1732746283"/>
<var name="faction" value="rlaan"/>
<var name="luminosity" value="0"/>
<var name="num_gas_giants" value="2"/>
<var name="num_moons" value="0"/>
<var name="num_natural_phenomena" value="0"/>
<var name="num_planets" value="1"/>
<var name="planetlist" value="planets.rlaan.txt"/>
<var name="sun_radius" value="16600.000000"/>
<var name="xyz" value="1168.837048 -267.182908 -256.453328"/>
<var name="jumps" value="Aantlbzz/Bzzzahb Aantlbzz/Tlaanbzz Aantlbzz/Azzyqqhzeen Pzzaztahber/Tl Aantlbzz/Zyqqhazz"/>
</system>

[gonzo]

It's a waste of time to try and find info about it. I've been on the forum, the wiki and the mailing lists and came up with nothing. Go work on the market instead.

[ezee]

Nah , it's good to know , and i will use and tweak that files you've found for the Market then !

Listen , just follow the titles and types of the args that follow , starting with seed :

void generateStarSystem( string datapath,
int seed,
string sector,
string system,
string outputfile,
float sunradius,
int numstars,
int numgasgiants,
int numrockyplanets,
int nummoons,
bool nebulae,
bool asteroids,
int numnaturalphenomena,
int numstarbases,
string factions,
string namelist,
const vector< string > &jumplocations )

That should work , tweak and tweak again , then we will update the wiki about it ?


But again , milky-way is the reference to use :

<sector name="Aantlbzz">
<system name="Aanpzezyqqh"><var name="planets" value="bsm"/>
<var name="data" value="-1732746283"/>
<var name="faction" value="rlaan"/>
<var name="luminosity" value="0"/>
<var name="num_gas_giants" value="2"/>
<var name="num_moons" value="0"/>
<var name="num_natural_phenomena" value="0"/>
<var name="num_planets" value="1"/>
<var name="planetlist" value="planets.rlaan.txt"/>
<var name="sun_radius" value="16600.000000"/>
<var name="xyz" value="1168.837048 -267.182908 -256.453328"/>
<var name="jumps" value="Aantlbzz/Bzzzahb Aantlbzz/Tlaanbzz Aantlbzz/Azzyqqhzeen Pzzaztahber/Tl Aantlbzz/Zyqqhazz"/>
</system>