Patch tracker needs some love
Patch tracker needs some love
I've pushed a few patches today and noticed that there are open patches that are a year old. Can they be reviewed, applied or rejected eventually?
What is the preferred way to contribute atm, the review board thingy seems to be gone/broken?
What is the preferred way to contribute atm, the review board thingy seems to be gone/broken?
-
- Elite
- Posts: 7243
- Joined: Mon Apr 18, 2005 2:40 pm
- Location: LS87, Buenos Aires, República Argentina
Re: Patch tracker needs some love
The server accident wiped the review board, and in any case the patch tracker is the way.
Old patches will probably be inapplicable currently. Though they have to be reviewed. I had reviewed some a while ago.
Any one in particular you have in mind?
Old patches will probably be inapplicable currently. Though they have to be reviewed. I had reviewed some a while ago.
Any one in particular you have in mind?
Re: Patch tracker needs some love
I think the outdated ones should be rejected. The gravity patch can be closed too, as it is "let's say very incomplete", should be developed in a branch maybe.
There are a few minimal ones, that shouldn't anything like the min/max cleanup. I can push updated versions btw.
I am testing with mingw/gcc, vs2010, would be great if @phoenixstorm could test them with vs2008 of course.
There are a few minimal ones, that shouldn't anything like the min/max cleanup. I can push updated versions btw.
I am testing with mingw/gcc, vs2010, would be great if @phoenixstorm could test them with vs2008 of course.
-
- Elite
- Posts: 1567
- Joined: Tue Jan 26, 2010 2:03 am
Re: Patch tracker needs some love
I and my branch have fallen a bit behind in everything though I did get a new binary up about tenish commits ago.
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
-
- The Shepherd
- Posts: 5841
- Joined: Fri May 13, 2005 8:37 pm
- Location: Ottawa
- Contact:
Re: Patch tracker needs some love
That and the windows version is now only available as a 64 bit binary,I am using the last 32 bit version.
Enjoy the Choice
Enjoy the Choice
my box::HP Envy i5-6400 @2Q70GHzx4 8 Gb ram/1 Tb(Win10 64)/3 Tb Mint 19.2/GTX745 4Gb acer S243HL K222HQL
Q8200/Asus P5QDLX/8 Gb ram/WD 2Tb 2-500 G HD/GF GT640 2Gb Mint 17.3 64 bit Win 10 32 bit acer and Lenovo ideapad 320-15ARB Win 10/Mint 19.2
Q8200/Asus P5QDLX/8 Gb ram/WD 2Tb 2-500 G HD/GF GT640 2Gb Mint 17.3 64 bit Win 10 32 bit acer and Lenovo ideapad 320-15ARB Win 10/Mint 19.2
-
- Insys Pilot
- Posts: 2
- Joined: Mon Oct 28, 2013 10:36 am
Re: Patch tracker needs some love
That and the windows version is now only available as a 64 bit binary,I am using the last 32 bit version.
If want to learn web designing then join E10-001 dumps web design course and download free COMPTIA tutorials and University of California, Los Angeles demos to learn how to create amazing background patterns for your web project. Best of luck,
-
- Elite Venturer
- Posts: 753
- Joined: Sat Apr 15, 2006 2:40 am
- Location: chthonic safety
Re: Patch tracker needs some love
Speaking of the tracker, this was " closed-accepted" at a testing version (before "MinWarp_05_1.diff" with fixed headers and improved functions).
"Two Eyes Good, Eleven Eyes Better." -Michele Carter
-
- The Shepherd
- Posts: 5841
- Joined: Fri May 13, 2005 8:37 pm
- Location: Ottawa
- Contact:
Re: Patch tracker needs some love
That looks like a good patch TB and any clean up is good
Enjoy the Choice
Enjoy the Choice
my box::HP Envy i5-6400 @2Q70GHzx4 8 Gb ram/1 Tb(Win10 64)/3 Tb Mint 19.2/GTX745 4Gb acer S243HL K222HQL
Q8200/Asus P5QDLX/8 Gb ram/WD 2Tb 2-500 G HD/GF GT640 2Gb Mint 17.3 64 bit Win 10 32 bit acer and Lenovo ideapad 320-15ARB Win 10/Mint 19.2
Q8200/Asus P5QDLX/8 Gb ram/WD 2Tb 2-500 G HD/GF GT640 2Gb Mint 17.3 64 bit Win 10 32 bit acer and Lenovo ideapad 320-15ARB Win 10/Mint 19.2
-
- Elite
- Posts: 1567
- Joined: Tue Jan 26, 2010 2:03 am
Re: Patch tracker needs some love
Don't know where you heard that from but we don't even HAVE a 64bit binary yet.mohsin123 wrote:That and the windows version is now only available as a 64 bit binary,I am using the last 32 bit version.
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
-
- The Shepherd
- Posts: 5841
- Joined: Fri May 13, 2005 8:37 pm
- Location: Ottawa
- Contact:
Re: Patch tracker needs some love
That's xNormal that is only 64 bit now And I deleted a spammers post that was in here so the context of thread is a bit screwed up
Enjoy the Choice
Enjoy the Choice
my box::HP Envy i5-6400 @2Q70GHzx4 8 Gb ram/1 Tb(Win10 64)/3 Tb Mint 19.2/GTX745 4Gb acer S243HL K222HQL
Q8200/Asus P5QDLX/8 Gb ram/WD 2Tb 2-500 G HD/GF GT640 2Gb Mint 17.3 64 bit Win 10 32 bit acer and Lenovo ideapad 320-15ARB Win 10/Mint 19.2
Q8200/Asus P5QDLX/8 Gb ram/WD 2Tb 2-500 G HD/GF GT640 2Gb Mint 17.3 64 bit Win 10 32 bit acer and Lenovo ideapad 320-15ARB Win 10/Mint 19.2
-
- Elite
- Posts: 1567
- Joined: Tue Jan 26, 2010 2:03 am
Re: Patch tracker needs some love
damn spammers...
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
-
- Elite
- Posts: 7243
- Joined: Mon Apr 18, 2005 2:40 pm
- Location: LS87, Buenos Aires, República Argentina
Re: Patch tracker needs some love
I thought I had committed MinWrap_05_1.diff. I guess I thought wrong.TBeholder wrote:Speaking of the tracker, this was " closed-accepted" at a testing version (before "MinWarp_05_1.diff" with fixed headers and improved functions).
Can you re-open the ticket?
-
- Elite Venturer
- Posts: 753
- Joined: Sat Apr 15, 2006 2:40 am
- Location: chthonic safety
Re: Patch tracker needs some love
The last one has ExpectAutoRampdownTime(...) and EnergyWarrantsWarp(...) in warpto.cpp - if these functions aren't here, it wasn't included.
I can't change status of anything. Or even tags on my own tickets (which is more annoying).
I can't change status of anything. Or even tags on my own tickets (which is more annoying).
"Two Eyes Good, Eleven Eyes Better." -Michele Carter
-
- Elite
- Posts: 7243
- Joined: Mon Apr 18, 2005 2:40 pm
- Location: LS87, Buenos Aires, República Argentina
Re: Patch tracker needs some love
It seems I have no way to give permissions to the ticket author, it's either all users in a group or nothing
Anyway, in those cases, you can post a comment asking for it to be reopened I guess.
I already reopened.
Anyway, in those cases, you can post a comment asking for it to be reopened I guess.
I already reopened.