Patch for removing InputDFA

Development directions, tasks, and features being actively implemented or pursued by the development team.
Post Reply
breese
Bounty Hunter
Bounty Hunter
Posts: 152
Joined: Thu Sep 02, 2010 8:00 pm

Patch for removing InputDFA

Post by breese »

The attached patch removes the InputDFA class, which has been replaced by FireKeyboard, FlyByKeyboard and FlyByJoystick back in 2002.

InputDFA was disabled by r4467, but somehow it was not removed from the repository. so I just wasted a lot of time trying to understanding the code before I discovered that it was dead code.
You do not have the required permissions to view the files attached to this post.
pheonixstorm
Elite
Elite
Posts: 1567
Joined: Tue Jan 26, 2010 2:03 am

Re: Patch for removing InputDFA

Post by pheonixstorm »

Ouch.
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
pheonixstorm
Elite
Elite
Posts: 1567
Joined: Tue Jan 26, 2010 2:03 am

Re: Patch for removing InputDFA

Post by pheonixstorm »

havent forgotten about this. I will get it resolved some time within the next week, maybe a lot sooner (I hope). Got sidetracked by trying to get access to the devblog and news sections of the front page... probably just gonna have to alter the register/install pages to create a backdoor to get myself registered... oh the horror.

OT: did anyone know that the previous forum is still active? http://vegastrike.sourceforge.net/phpbb2/ just dont check out the latest posts made by the bots... weeks worth of porn advertising :shock:
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
breese
Bounty Hunter
Bounty Hunter
Posts: 152
Joined: Thu Sep 02, 2010 8:00 pm

Re: Patch for removing InputDFA

Post by breese »

pheonixstorm wrote:havent forgotten about this. I will get it resolved some time within the next week, maybe a lot sooner (I hope).
Ok. Does this also apply to my boost patch?
pheonixstorm
Elite
Elite
Posts: 1567
Joined: Tue Jan 26, 2010 2:03 am

Re: Patch for removing InputDFA

Post by pheonixstorm »

I completely missed that one, thanks for the link and yes. The only change might be to not get rid of 1.28 just yet (grr... we need a poll on user OSes) until we know that those pesky obsolete macs aren't getting used any more.
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
ace123
Lead Network Developer
Lead Network Developer
Posts: 2560
Joined: Sun Jan 12, 2003 9:13 am
Location: Palo Alto CA
Contact:

Re: Patch for removing InputDFA

Post by ace123 »

pheonixstorm wrote:OT: did anyone know that the previous forum is still active? http://vegastrike.sourceforge.net/phpbb2/ just dont check out the latest posts made by the bots... weeks worth of porn advertising :shock:
(This post is OT)
Holy cow, good find.
Wow, I intended to keep it just for the transision to phpbb3 (two years ago!). it even made its way to google's search index. Probably riddled with SQL Injection holes too. Just ran "chmod -x" and marked it as 410 Gone to remove the spam from Google's index hehe.

By the way, please do remove any dead code if you can (though watch out--some things look like dead code replaced by something else, but occasionally there will be one or two components which still need it)
pheonixstorm
Elite
Elite
Posts: 1567
Joined: Tue Jan 26, 2010 2:03 am

Re: Patch for removing InputDFA

Post by pheonixstorm »

I reviewed the diff, even did a search in the afflicted files and its pretty dead end in. a call to new, some commented out code that actually did the work, then a call to delete. Odd thing here is the main body of code was commented out but not the new/delete code :roll:
Because of YOU Arbiter, MY kids? can't get enough gas. OR NIPPLE! How does that mkae you feeeel? ~ Halo
Post Reply